set seperate client for updating pod status #3073
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/M
|
I think we need to find out why the pod status message is updated in every session. Actually, it does not need to do update if the pod's condition has no change. The qps limiit can not solve the root cause and will cause scheduling latency or update conflicts(if update is in different goroutine in different session) |
|
/hold |
volcano-sh-bot
added
the
do-not-merge/hold
details have been added to issue. |
Signed-off-by: Xuzheng Chang <[email protected]>
| func NewPodStatusClient(config *rest.Config) (*kubernetes.Clientset, error) { | ||
| configShallowCopy := *config | ||
| qps := os.Getenv("POD_STATUS_CLIENT_QPS") | ||
| if qps != "" { |
There was a problem hiding this comment.
how about qps is not set in env? what's default qps? use kubeclient's default one?
There was a problem hiding this comment.
if not set env, we will use config, which is configed by cmd flag param and consistent with other kube client.
| configShallowCopy.Burst = burstInt | ||
| } | ||
|
|
||
| client, err := kubernetes.NewForConfig(&configShallowCopy) |
There was a problem hiding this comment.
Here, we can use AddUserAgent to specify an identity to distinguish from the default client.
|
/hold cancel |
volcano-sh-bot
removed
the
do-not-merge/hold
|
/close |
|
@Monokaix: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fix #3072