-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Ginkgo options --progress and --slow-spec-threshold #3814
Remove deprecated Ginkgo options --progress and --slow-spec-threshold #3814
Conversation
For your reference: https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md#250 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
But there are other errors in CI |
Could this be due to resource limitations in the CI environment? It seems like the jobs are failing all the time.Or it's because of some resource allocation or scheduling problem. |
I'll check this |
Please rebase the new master branch because CI has been fixed: #3817 |
06bdf9e
to
2f3fd1d
Compare
Signed-off-by: Sa Song <[email protected]>
2f3fd1d
to
f82f82f
Compare
rebased. |
Please modify the describe. delete some useless errors. Such as,
|
modified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
Is there some changs of ginkgo output for users when these flags are removed and new flags are added? |
Yes, the console output may change and it has stronger guarantees if using the JSON format to build tooling on top of. |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When I pr #3811 and I find the E2E tests failed.When I investigate the problem, I find
This pr is to remove deprecated Ginkgo options --progress and --slow-spec-threshold.