-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added search query functionality without page redirection #345
Added search query functionality without page redirection #345
Conversation
Welcome @shruti78! |
/assign @kevin-wangzefeng |
Hi, thanks for your contribution! Please signoff your commit with |
9107b10
to
7740b71
Compare
@Monokaix done |
After I typed something in the search field and pressed Enter, the page still refreshed, is it our expectation? |
@JesseStutler Resolved the issue where page redirection occurred upon Pressing Enter, ensuring the user remains on the intended page. Also verified that refreshing is not causing any unintended navigation issues. Also resolved the problem where the search query entered in the navbar was not being retained in the search bar after redirection on clicking Search button. Screencast.from.06-02-25.11.59.26.AM.IST.webmAny further suggestions/ changes would be appreciated. |
@JesseStutler in short i solved:-
|
@JesseStutler please review it now !! |
The phenomenon I encountered:
Maybe you should deploy locally and check carefully |
I feel page redirection on pressing enter was our main concern, it refereshes the page while reloading. |
It looks like it's a bit more correct now, but the refresh still exists, it still refreshes the page and then show the results, instead of showing the search results directly, is this what we expect? If is's hard to implement, I think current is fine |
I encountered why this is happening , |
@JesseStutler @kevin-wangzefeng @Monokaix isnt this PR Satisfiable |
Please rebase master and squash to one commit: ) |
Signed-off-by: Shruti78 <[email protected]>
f04da2e
to
6c06bb7
Compare
@Monokaix done
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR resolves the issue #343
No suggestions appeared while typing in the search bar.
Pressing "Enter" caused a redirection instead of showing search results on the same page.
Changes Implemented:
Steps to Test: