Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search query functionality without page redirection #345

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Shrutim1505
Copy link
Contributor

@Shrutim1505 Shrutim1505 commented Feb 5, 2025

This PR resolves the issue #343

No suggestions appeared while typing in the search bar.
Pressing "Enter" caused a redirection instead of showing search results on the same page.

Changes Implemented:

  • Added functionality to display search suggestions dynamically while typing in the search field.
  • Modified search logic to prevent page redirection and display results on the same page.

Steps to Test:

  • Start typing in the search field.
  • Ensure suggestions appear as you type.
  • Press "Enter" to see the search results displayed on the same page without redirection.

@volcano-sh-bot
Copy link
Collaborator

Welcome @shruti78!

It looks like this is your first PR to volcano-sh/website.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2025
@Shrutim1505 Shrutim1505 changed the title Added search query functionality without page redirection Added search query functionality without page redirection #343 Feb 5, 2025
@Shrutim1505 Shrutim1505 changed the title Added search query functionality without page redirection #343 Added search query functionality without page redirection Feb 5, 2025
@Shrutim1505
Copy link
Contributor Author

/assign @kevin-wangzefeng

@Monokaix
Copy link
Member

Monokaix commented Feb 6, 2025

Hi, thanks for your contribution! Please signoff your commit with git commit -s.

@Shrutim1505
Copy link
Contributor Author

Hi, thanks for your contribution! Please signoff your commit with git commit -s.

@Monokaix done

@JesseStutler
Copy link
Member

After I typed something in the search field and pressed Enter, the page still refreshed, is it our expectation?

@Shrutim1505
Copy link
Contributor Author

Shrutim1505 commented Feb 6, 2025

@JesseStutler Resolved the issue where page redirection occurred upon Pressing Enter, ensuring the user remains on the intended page. Also verified that refreshing is not causing any unintended navigation issues.

Also resolved the problem where the search query entered in the navbar was not being retained in the search bar after redirection on clicking Search button.

Screencast.from.06-02-25.11.59.26.AM.IST.webm

Any further suggestions/ changes would be appreciated.

@Shrutim1505
Copy link
Contributor Author

Shrutim1505 commented Feb 6, 2025

@JesseStutler in short i solved:-

  • Current Page don't redirects to another page on clicking "ENTER"
  • When the search query entered in the navbar , query is retained in the search bar on clicking the Search icon.

@JesseStutler
Copy link
Member

You can see the rendering here, click the details button, the website deployed on netlify:
image

Have you updated your codes? After I clicked Enter, the page still got refreshed, the effect should be to show the search results directly on the page without refresh, right?

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2025
@Shrutim1505
Copy link
Contributor Author

@JesseStutler please review it now !!
completed the functionality of dynamic rendering

@JesseStutler
Copy link
Member

The phenomenon I encountered:

  1. When I type something and click the search button, there is nothing shown in the search results, and then immediately refreshed
  2. When I use enter to search, there are indeed search results shown, but still refreshed the page

Maybe you should deploy locally and check carefully

@Shrutim1505
Copy link
Contributor Author

The phenomenon I encountered:

  1. When I type something and click the search button, there is nothing shown in the search results, and then immediately refreshed
  2. When I use enter to search, there are indeed search results shown, but still refreshed the page

Maybe you should deploy locally and check carefully

I feel page redirection on pressing enter was our main concern, it refereshes the page while reloading.
however " When I type something and click the search button, there is nothing shown in the search results, and then immediately refreshed" would be taken into consideration.
Apology for the confusion

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2025
@JesseStutler
Copy link
Member

The phenomenon I encountered:

  1. When I type something and click the search button, there is nothing shown in the search results, and then immediately refreshed
  2. When I use enter to search, there are indeed search results shown, but still refreshed the page

Maybe you should deploy locally and check carefully

I feel page redirection on pressing enter was our main concern, it refereshes the page while reloading. however " When I type something and click the search button, there is nothing shown in the search results, and then immediately refreshed" would be taken into consideration. Apology for the confusion

It looks like it's a bit more correct now, but the refresh still exists, it still refreshes the page and then show the results, instead of showing the search results directly, is this what we expect? If is's hard to implement, I think current is fine

@Shrutim1505
Copy link
Contributor Author

The phenomenon I encountered:

  1. When I type something and click the search button, there is nothing shown in the search results, and then immediately refreshed
  2. When I use enter to search, there are indeed search results shown, but still refreshed the page

Maybe you should deploy locally and check carefully

I feel page redirection on pressing enter was our main concern, it refereshes the page while reloading. however " When I type something and click the search button, there is nothing shown in the search results, and then immediately refreshed" would be taken into consideration. Apology for the confusion

It looks like it's a bit more correct now, but the refresh still exists, it still refreshes the page and then show the results, instead of showing the search results directly, is this what we expect? If is's hard to implement, I think current is fine

I encountered why this is happening ,
its because of outdated packages, the functionality is slower as it acts. I am updating code base to remove this issue.

@Shrutim1505
Copy link
Contributor Author

@JesseStutler @kevin-wangzefeng @Monokaix isnt this PR Satisfiable

@Monokaix
Copy link
Member

Please rebase master and squash to one commit: )

Signed-off-by: Shruti78 <[email protected]>
@Shrutim1505
Copy link
Contributor Author

@Monokaix done

Please rebase master and squash to one commit: )

@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2025
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@volcano-sh-bot volcano-sh-bot merged commit 815ad71 into volcano-sh:master Feb 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants