-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Dockerfile two-staged #472
Conversation
nice things we can have with only thing i would have preferred is to not re-format the unchanged lines, as this now replaces the whole file. @mbehr1: should we test the Dockerfile as part of the cI checks? can we do that conditionally only if it was changed? or maybe just replace the build with the dockerfile build? questions, questions... |
About the unchanged lines: I know what you mean. Since I removed the sudo and subversion package and extra spaces and the line endings, there are only few unchanged lines. And this format will make changes to packages cleaner. But if you like I can format the apt line as previous. |
imho good to merge, |
actually that's probably the reason for noting this, btw. |
Maybe makes sense to link everything static , also the other dependencies. That way the image will stay smaller as no libs need to be installed. |
I think a complete static version would be great. But this needs work from a person with more knowledge of the c build chain. |
run in user context add foreground option Add comment about static libsml fix grammer in comment
inside docker it doesn't make a difference, |
run in user context
add foreground option