Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] print warning if oms not enabled #644

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

r00t-
Copy link
Contributor

@r00t- r00t- commented Apr 3, 2024

this is the possible learning from #642 :
print a warning if oms is not being enabled, just like for sml.

questions:

  • this means the warning will be printed for most users, is this OK or possibly confusing?
  • code-wise there's three variables involved (like for sml):
    • ENABLE_*: user inpput to request feature (set by default)
    • *_FOUND: result of library search
    • *_SUPPORT: set conditional if feature can be enabled
      the sml warning uses ENABLE AND NOT FOUND,
      i rather use ENABLE AND NOT SUPPORTED to avoid duplicating the decision process.
      but it's inconsistent... but probably irrelevant.

@narc-Ontakac2
Copy link
Collaborator

Enabling by default is OK in my opinion.

I will also add a note to the Debian section of the README that oms is not enabled. This is because the library is not packaged.

@r00t-
Copy link
Contributor Author

r00t- commented Apr 24, 2024

just merging this

@r00t- r00t- merged commit 6e71155 into volkszaehler:master Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants