feat: prefer inline in slice_ref

volo-rs · Sep 5, 2024 · 68ddbea · 68ddbea
1 parent f5ea63e
commit 68ddbea
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 10 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "faststr"
-version = "0.2.22"
+version = "0.2.23"
 authors = ["Volo Team <[email protected]>"]
 edition = "2021"
 description = "Faststr is a string library that reduces the cost of clone."

diff --git a/src/lib.rs b/src/lib.rs
@@ -229,8 +229,14 @@ impl FastStr {
     }
 
     /// Return a new `FastStr` that represents a subset of the current string.
+    ///
+    /// Note: If the subset is small enough, it will be inlined.
     #[inline(always)]
     pub fn slice_ref(&self, subset: &str) -> Self {
+        if subset.len() <= INLINE_CAP {
+            // Safety: we have checked the length of subset <= `INLINE_CAP`.
+            return Self(unsafe { Repr::new_inline_impl(subset) });
+        }
         Self(self.0.slice_ref(subset.as_bytes()))
     }