added constructor generation #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodya-lombrozo
requested changes
Jan 28, 2025
There was a problem hiding this comment.
@qoxrdw Thank you for the contribution! Just a few small comments.
| ; | ||
|
|
||
| constructorBody | ||
| : '{' '}' |
There was a problem hiding this comment.
@qoxrdw Can we use methodBlock instead of constructorBody here?
There was a problem hiding this comment.
Yes, we can use it if we want the constructor body not to be empty. I'll add this.
| classBody /* $jsmith-scope */ | ||
| : '{' classBodyDeclaration+ '}' NL | ||
| : '{' constructorDeclaration classBodyDeclaration+'}' NL |
There was a problem hiding this comment.
@qoxrdw Class might be without a constructor. Maybe we can make constuctorDeclaration optional? What do you think?
There was a problem hiding this comment.
Yes, I agree, I'll add this.
volodya-lombrozo
approved these changes
Jan 29, 2025
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 4min). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added constructor generation
also added a new puzzle for it
PR for issue #15