Stop running use_legacy_dataset=true for wide-benchmark
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ["true"], | ||
| ["false"], | ||
| ) | ||
| valid_cases = (["use_legacy_dataset"], ["false"]) | ||
|
|
||
| def run(self, case=None, **kwargs): | ||
| path = os.path.join(_sources.temp_dir, "wide.parquet") |
There was a problem hiding this comment.
A bit below, on line 36, you can remove the use_legacy_dataset=legacy part.
We can keep the parametrization to preserve the history of the benchmark, but in the benchmark code itself we can now remove any usage of it (we will also deprecate/remove that keyword at some point, and then this is already ready for that)
| ["true"], | ||
| ["false"], | ||
| ) | ||
| valid_cases = (["use_legacy_dataset"], ["false"]) |
There was a problem hiding this comment.
Maybe add a comment that this parameter is only kept for historical reasons, but is further ignored nowadays?
jorisvandenbossche
approved these changes
Jan 8, 2024
Pull Request Test Coverage Report for Build 7450409612
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See apache/arrow#39112