Add support for location event sent from GPS tracker board GT02_MT6261D_V2.3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vondraussen
reviewed
Feb 11, 2020
| @@ -86,6 +89,9 @@ function selectEvent(data) { | |||
| case 0x12: | |||
| eventStr = 'location'; | |||
| break; | |||
| case 34: | |||
There was a problem hiding this comment.
I'd prefer to have a hex case :)
and It could be added below the case 0x12 since it is the same code.
case 0x12:
case 0x22:
Object.assign.....
vondraussen
requested changes
Feb 11, 2020
vondraussen
reviewed
Feb 11, 2020
| @@ -30,6 +30,9 @@ Gt06.prototype.parse = function (data) { | |||
| case 0x12: // location message | |||
| Object.assign(parsed, parseLocation(msg)); | |||
| break; | |||
| case 34: // location message | |||
There was a problem hiding this comment.
same same
merge with case for 0x12
|
hello, I'm not getting the status of the inginition, it always returns false. are you with this detail too? |
I think you need to ask @chrispahm since I don't have a GT02_MT6261D_V2.3. |
|
Hey @saulo1212, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support e.g the following tracker
https://www.amazon.de/Likorlove-Monitoring-Ortungsger%C3%A4t-Kostenlos-Smartphone-Schwarz-ohne-Batterie/dp/B07KR98Q4V