Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement examplary topics #49

Merged
merged 9 commits into from
Oct 7, 2024

Conversation

philipp-caspers
Copy link
Member

@philipp-caspers philipp-caspers commented Oct 2, 2024

this PR fully implements the following ROS topics:

  • joint_states
  • tcp_pose
  • tcp_twist
  • tcp_wrench

for `PoseStamped`, `TwistStamped`, `WrenchStamped` and `JointState`.
in order to be able to properly create the `joint_states` topic which
has to be assembled from three diffent OPC UA nodes.
where for now all OPC UA nodes are statically linked with their
corresponding (ROS-)callbacks.
meaning that from now on all fiels of the JoinStates message are filled
with real data.
which is replaced by the `ros_message_creation` module.
which is the port of the robot control of the voraus core.
@philipp-caspers philipp-caspers marked this pull request as ready for review October 2, 2024 14:58
Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die Port-Änderung streut mir etwas zu doll und grundsätzlich hätten das mehr PR werden dürfen.
Das hat schon ein bisschen gedauert. Ich hoffe nichts übersehen zu haben, aber das war dicht an dem, was wir nachmittags besprochen haben.

@philipp-caspers philipp-caspers merged commit 8a6c163 into main Oct 7, 2024
6 checks passed
@philipp-caspers philipp-caspers deleted the feat/implement-variable-endpoints branch October 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants