feat: Add better compose defaults #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-caspers
force-pushed
the
chore/add-better-compose-defaults
branch
from
2eef610 to
463cfc8
Compare
philipp-caspers
changed the title
We assume that the typical user will either have ROS installed on the host or uses multiple containers connected via the hosts network.
This should act as a living documentation.
This is a workaround for the `special` signal handling of ros2 launch. To stop a process docker sends a SIGTERM on default. The ros2 launch wrapper however ignores SIGTERM (only SIGINT is considered). Docker then sends a SIGKILL after a timeout. As a result, the shutdown times of the container are at least as long as the timeout. This change makes docker send SIGINT instead of SIGTERM, resulting in proper fast shutdown. See ros2/launch#666 for details.
philipp-caspers
force-pushed
the
chore/add-better-compose-defaults
branch
from
463cfc8 to
040ecff
Compare
philipp-caspers
requested review from
AiyionPrime,
DS424 and
tobiasbrinker
as code owners
tobiasbrinker
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the overall experience when starting the bridge via docker compose.