chore: add mit license #62
Conversation
julianoeltjen
requested review from
AiyionPrime,
philipp-caspers,
DS424 and
tobiasbrinker
as code owners
| ENV PATH=/home/$USERNAME/.cargo/bin:$PATH | ||
| RUN cargo install cargo-ament-build | ||
| RUN cargo install cargo-ament-build cargo-deny |
There was a problem hiding this comment.
We should at least document how to use this or even better integrate it into the pipeline.
In case it's just for one-time manual license inspection, we should not permanently add it to the dev container.
There was a problem hiding this comment.
This is now the only thing left to decide in this PR.
Either we leave it out, or we put it in with documentation or at least a pipeline run.
| @@ -1560,3 +1560,7 @@ version = "2.2.1" | |||
| [[patch.unused]] | |||
| name = "visualization_msgs" | |||
| version = "4.2.4" | |||
|
|
|||
There was a problem hiding this comment.
This is unnecessary and causes the pipeline to fail (The creation of this section is a current inconvenience of the build process, sorry for that)
|
@philipp-caspers I spoke to @julianoeltjen and suggested to take over from here. |
| ENV PATH=/home/$USERNAME/.cargo/bin:$PATH | ||
| RUN cargo install cargo-ament-build | ||
| RUN cargo install cargo-ament-build cargo-deny |
There was a problem hiding this comment.
This is now the only thing left to decide in this PR.
Either we leave it out, or we put it in with documentation or at least a pipeline run.
added MIT license
license check of dependencies with cargo-deny has been performed, dependencies are licensed under
which are compatible with MIT.