-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add configurable frame id prefix #66
Conversation
9cbf56a
to
41e9aa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I am not a rust expert, my review might not be that helpful. But I spend quite a lot of time trying to understand it line to line and what I could unterstand looks good
I have not had time to look into this, just wanted to leave this here for now: Asking questions in PRs is a great way to have the answers to them near the relevant context and can be of great use to others a few weeks/months/years down the road. |
in order to avoid the explicitly coupled copy variables.
48fb89f
to
fd8f5ec
Compare
fd8f5ec
to
8f805ad
Compare
In order to be able to properly handle (e.g. visualize) a multi robot scenario (where multiple voraus.core instances and bridges are running), one need the ability to distinguish between the coordinate systems of the different robots.
This change introduces an environment variable (
FRAME_ID_PREFIX
) to solve that problem.The default value defined in the compose file is
robot1
, meaning that for example for thebase_link
coordinate system, the resulting frame_id is now:robot1_base_link
.