Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configurable frame id prefix #66

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

philipp-caspers
Copy link
Member

@philipp-caspers philipp-caspers commented Dec 6, 2024

In order to be able to properly handle (e.g. visualize) a multi robot scenario (where multiple voraus.core instances and bridges are running), one need the ability to distinguish between the coordinate systems of the different robots.
This change introduces an environment variable (FRAME_ID_PREFIX) to solve that problem.
The default value defined in the compose file is robot1, meaning that for example for the base_link coordinate system, the resulting frame_id is now: robot1_base_link.

@philipp-caspers philipp-caspers force-pushed the feat/frame-id-prefix branch 3 times, most recently from 9cbf56a to 41e9aa0 Compare December 6, 2024 15:33
@philipp-caspers philipp-caspers marked this pull request as ready for review December 6, 2024 15:42
Copy link

@AguilaTaco AguilaTaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am not a rust expert, my review might not be that helpful. But I spend quite a lot of time trying to understand it line to line and what I could unterstand looks good

compose.yaml Show resolved Hide resolved
src/register_subscriptions.rs Show resolved Hide resolved
@AiyionPrime
Copy link
Member

I have not had time to look into this, just wanted to leave this here for now:
Whether someone is proficient in a specific field does IMO not influence the usefulness of PRs greatly. Either the code author or the reviewer learns something, ideally both.

Asking questions in PRs is a great way to have the answers to them near the relevant context and can be of great use to others a few weeks/months/years down the road.
Do never hesitate to ask.

src/main.rs Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/register_subscriptions.rs Show resolved Hide resolved
compose.yaml Show resolved Hide resolved
in order to avoid the explicitly coupled copy variables.
@philipp-caspers philipp-caspers force-pushed the feat/frame-id-prefix branch 2 times, most recently from 48fb89f to fd8f5ec Compare December 16, 2024 11:57
@philipp-caspers philipp-caspers merged commit 3283db4 into main Dec 16, 2024
7 checks passed
@philipp-caspers philipp-caspers deleted the feat/frame-id-prefix branch December 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants