feat!: Allow different OPC UA arg types #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous `Vec<T>` solution could not handle different argument types for the `call_method` method of the opc_ua_client although it's very common to have those. Hence, this change uses the OPC UA Variant type for the arguments, which eliminates this drawback.
philipp-caspers
requested review from
AiyionPrime,
DS424 and
tobiasbrinker
as code owners
DS424
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
Vec<T>solution could not handle different argument types for thecall_methodmethod of the opc_ua_client although it's very common to have those.Hence, this change uses the OPC UA Variant type for the arguments, which eliminates this drawback.