test: Add generic service type support to the service caller #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-caspers
force-pushed
the
test/generic-service-caller
branch
from
0f1a649 to
b68e784
Compare
philipp-caspers
force-pushed
the
test/rework-tests
branch
from
0ba1dea to
7f1f4d1
Compare
philipp-caspers
force-pushed
the
test/generic-service-caller
branch
from
b68e784 to
6640881
Compare
philipp-caspers
requested review from
AiyionPrime,
DS424 and
tobiasbrinker
as code owners
DS424
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to call arbitrary ROS services (with arbitrary arguments) from within the integration tests against the ROS bridge, we need the
ros_service_callerto be suitable for every service type, not just empty.Hence, the service caller was templated.