Fix bug where empty string is a valid focusKey

vovacodes · Sep 2, 2021 · 5ffc39b · 5ffc39b
1 parent 12255c9
commit 5ffc39b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/react-sunbeam/package.json b/packages/react-sunbeam/package.json
@@ -1,6 +1,6 @@
 {
     "name": "react-sunbeam",
-    "version": "2.0.0-beta.2",
+    "version": "2.0.0-beta.3",
     "description": "Spatial navigation and focus management for React",
     "keywords": [
         "spatial-navigation",

diff --git a/packages/react-sunbeam/src/focus/FocusableNode.ts b/packages/react-sunbeam/src/focus/FocusableNode.ts
@@ -31,7 +31,7 @@ export class FocusableNode implements IFocusableNode {
         customGetPreferredChild?: CustomGetPreferredChildFn
         lock: Direction[] | Direction | undefined
     }) {
-        focusKey = focusKey ?? `focusable:${randomId()}`
+        focusKey = focusKey || `focusable:${randomId()}`
         this.focusKey = focusKey
         this.path = [...parentPath, focusKey]
         this.getBoundingBox = getBoundingBox