Added timeout option and improve error messages #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-classen
commented
May 21, 2014
philipp-classen
commented
- New timeout option (defaults to 0)
- Nicer error messages if err != null
- Nicer error messages if err != null
|
I don't think the build breaks because of this patch. When I run "npm test" locally against the current master, the upload test fails, too: $ npm test Before tests begin ✗ Errored » Asynchronous Error ✗ Errored » callback not fired |
added 2 commits
June 3, 2014 15:17
callback was not fired if the file was not found
|
new: Added support for OPTIONS requests + fixed a missing callback in 'upload' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.