-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unescape for paths before reading files #188
Conversation
👍 |
Would it be easy to add a test for that so it doesn't break again? Otherwise this looks good to merge. |
I'll have a look at it. |
I found a spot where we didn't use |
If you think it's not too hard to replicate, then I think it'd be good to add a test for it, but if it's hard, then don't bother (and merge this!) |
The again, the build is failing |
Strange, on my machine, using Ruby 2.0.0, the tests all pass. |
Now it worked without that I've changed anything with respect to the previously failing test. Strange, maybe execution order plays a role here. |
Use unescape for paths before reading files
This re-fixes #100 (it was fixed until the last commit in #174 introduced
convert_path
).