-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Set crm as default provider for ubuntu #538
base: master
Are you sure you want to change the base?
Conversation
Hey @dploeger, |
8a5f888
to
9fe5e44
Compare
@zilchms Rebased this. How can you change the defaultfor parameter of the provider using the hieradata? |
@zilchms After rebasing, some checks still fail and it doesn't seem it is because of my changes |
@zilchms @bastelfreak Can somebody take a look at this please? |
@dploeger can you please take a look at the failing test? |
@bastelfreak Hm. I can't recreate the failure locally and the other test suites were fine. Can you restart the failing test maybe? |
I restarted it, but the error stays |
77c6a42
to
e55b686
Compare
@bastelfreak I'm a bit baffled by this. If I read the code right, it expects an execution with a specific value but the actual execution misses a bracket. I don't think this is because of my code change, but I can't see why this happens at all. Do you have any idea? |
Pull Request (PR) description
Sets CRM as the default provider for Ubuntu machines.
This Pull Request (PR) fixes the following issues
none (can create one if required)
I couldn't test the unit tests because of #536 It works in our environment though.