-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade test version #440
base: master
Are you sure you want to change the base?
Upgrade test version #440
Conversation
a991f42
to
59be56a
Compare
59be56a
to
8c47726
Compare
} | ||
|
||
class { 'jira': | ||
version => '8.16.0', | ||
version => '9.12.18', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version parameter in init.pp still defaults to 8. Should that be updated as well? Or do we want to keep the old version and test if the module can upgrade jira 8 to 9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jira 8.x, which has been eol a year now, does not support Java 17.
I guess most module users have moved to 9 by now, so I vote for bumping the default version :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully that will solve the Debian 12/Ubuntu 24.04 issues as well.
'RedHat' => 'java-11-openjdk-headless', | ||
'Debian' => 'openjdk-11-jre-headless', | ||
'RedHat' => 'java-17-openjdk-headless', | ||
'Debian' => 'openjdk-17-jdk-headless', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module doesn't really support java17 that well ..
https://github.com/voxpupuli/puppet-jira/blob/master/types/jvm_types.pp
puppet-jira/manifests/config.pp
Lines 29 to 33 in 7945c72
if $jira::jvm_type == 'openjdk-11' { | |
$jvm_gc_args = '-XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent' | |
} else { | |
$jvm_gc_args = '-XX:+ExplicitGCInvokesConcurrent' | |
} |
Raise Jira Test Version to 9.12.18