Merge pull request #321 from bastelfreak/rules

vrrp::instance: virtual_rules: Enforce Array datatype
voxpupuli · Apr 2, 2024 · ac3cc53 · ac3cc53
2 parents 06f2228 + e3c435a
commit ac3cc53
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/REFERENCE.md b/REFERENCE.md
@@ -1154,11 +1154,11 @@ Default value: `undef`
 
 ##### <a name="-keepalived--vrrp--instance--virtual_rules"></a>`virtual_rules`
 
-Data type: `Optional[Array[Keepalived::Vrrp::Instance::VRule]]`
+Data type: `Array[Keepalived::Vrrp::Instance::VRule]`
 
 Set floating rules.
 
-Default value: `undef`
+Default value: `[]`
 
 ##### <a name="-keepalived--vrrp--instance--virtual_ipaddress_excluded"></a>`virtual_ipaddress_excluded`
 

diff --git a/manifests/vrrp/instance.pp b/manifests/vrrp/instance.pp
@@ -217,7 +217,7 @@
   $virtual_ipaddress_excluded                                             = undef,
   Boolean $promote_secondaries                                            = false,
   $virtual_routes                                                         = undef,
-  Optional[Array[Keepalived::Vrrp::Instance::VRule]] $virtual_rules       = undef,
+  Array[Keepalived::Vrrp::Instance::VRule] $virtual_rules                 = [],
   $smtp_alert                                                             = false,
   $nopreempt                                                              = false,
   $preempt_delay                                                          = undef,

diff --git a/templates/vrrp_instance.erb b/templates/vrrp_instance.erb
@@ -209,7 +209,7 @@ vrrp_instance <%= @_name %> {
   <%- end -%>
   }
   <%- end -%>
-  <%- if @virtual_rules -%>
+  <%- unless @virtual_rules.empty? -%>
 
   virtual_rules {
   <%-  @virtual_rules.each do |rule| -%>