Introduce support for Gentoo #79
Conversation
NiklausHofer
force-pushed
the
gentoo
branch
2 times, most recently
from
c568a24
to
0dd50d4
Compare
|
Sorry, I don't understand how I need to fix the formatting. If anyone could help me with that, I would certainly appreciate it. Also, this is probably not a very elegant solution in the first place, so if you have a better solution in mind, just let me know. |
|
Thank you for the extensive feedback. I'll have a closer look on Tuesday evening and update the pull request then. |
Gentoo has the Proosdy community modules packaged, so there is no need to manually manage their installation through Mercurial / Git.
As suggested by @smortex.
NiklausHofer
force-pushed
the
gentoo
branch
from
970f161
to
4af2f25
Compare
|
OK, I have rebased on the masterr and implemented the changes you suggested. |
|
I have incorporated your feedback now. I did not add the manage_package option though as I don't think it makes much sense here. If someone wants to have the OS package installed but not by Puppet or through Puppet but somewhere else in their code can just not use the community_package module since that is all it does really. |
I dunno, I've never done this...
NiklausHofer
force-pushed
the
gentoo
branch
from
e5b9f49
to
38e4f26
Compare
| @@ -7,14 +7,27 @@ | |||
| os_facts | |||
| end | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This blank line makes rubocop unhappy 😉
Pull Request (PR) description
This PR introduces support for Gentoo. As packaged in
net-im/prosody, Prosody uses some path which differ from the ones hardcoded in the module. This PR makes these paths configurable and it introduces the correct defaults for Gentoo.Additionally, the community modules are packaged for Gentoo and the PR introduces support for that, too.