Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Integer to print_recursive #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add Integer to print_recursive #90

wants to merge 2 commits into from

Conversation

trefzer
Copy link
Contributor

@trefzer trefzer commented Nov 25, 2021

Integers in Lua should not be printed as strings but as Integers !

smortex
smortex requested changes Nov 26, 2021
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an example in the tests (see spec/defines/virtualhost_spec.rb) to ensure we do not break this in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex requested changes

Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trefzer @smortex