Add support for CentOS 8, Debian 10 #115
Conversation
dhoppe
added
enhancement
|
The acceptance tests need to be refactored, because they are written for Vagrant. |
|
You can also ensure the user before hand: puppet-wget/spec/acceptance/wget_system_spec.rb Lines 31 to 33 in f286e42 That part runs as root and can create the user if needed. Should be the easiest fix. |
|
This module is broken in so many ways and I do not know, why it has not been archived in favour of Even if I remove the |
| package { 'wget': ensure => $version } | ||
| } | ||
| elsif $::kernel == 'FreeBSD' { | ||
| elsif $facts['kernel'] == 'FreeBSD' { | ||
| if versioncmp($facts['os']['release']['major'], '10') >= 0 { |
There was a problem hiding this comment.
This is the only supported version, so you can simplify this whole block.
| @@ -1,7 +1,7 @@ | |||
| require 'spec_helper_acceptance' | |||
|
|
|||
| describe 'wget' do | |||
| let(:wget_manifest) { "class { 'wget': }" } | |||
| let(:wget_manifest) { "user { 'vagrant': ensure => present, managehome => true } -> class { 'wget': }" } | |||
There was a problem hiding this comment.
I'd keep this local to the user test since it's not needed as part of the other tests.
|
why we consume energy to maintain a deprecated module ? |
|
IMO we should set this module in archive mode. |
It's a dependency of some of our other modules though??? Fix up those first? |
Maybe not ours... I have |
|
Going to close this since it's deprecated. See #119. |
No description provided.