Button for exporting tables as csv #429

emlun007 · 2017-10-19T14:01:23Z

Changes are made in layout.html and button libraries were added:

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.1.32/pdfmake.min.js"></script> 
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.1.32/vfs_fonts.js"></script>
<script type="text/javascript" src="https://cdn.datatables.net/v/dt/jszip-2.5.0/dt-1.10.16/b-1.4.2/b-html5-1.4.2/b-print-1.4.2/datatables.min.js"></script>

Changes are made in layout.html and button libraries were added: <link rel="stylesheet"String type="text/css"String href="https://cdn.datatables.net/v/dt/jszip-2.5.0/dt-1.10.16/b-1.4.2/b-html5-1.4.2/b-print-1.4.2/datatables.min.css"String/> <script type="text/javascript"String src="https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.1.32/pdfmake.min.js"String></script> <script type="text/javascript"String src="https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.1.32/vfs_fonts.js"String></script> <script type="text/javascript"String src="https://cdn.datatables.net/v/dt/jszip-2.5.0/dt-1.10.16/b-1.4.2/b-html5-1.4.2/b-print-1.4.2/datatables.min.js"String></script>

WIP: button for exporting tables as csv

Button for export finally works

larsnaesbye · 2017-10-30T10:35:56Z

@mterzo : Have you taken a look at this and can you comment on what is needed for it to be merged.

mterzo · 2017-10-30T14:18:59Z

CI is failing on the comment I made earlier. There are a bunch of JavaScript files added for local mode but I don’t see those files in the commits.

There was a major refactor of moving all the JavaScript to cacheable files instead of having all the JavaScript in HEAD of the html. We need make sure we don’t regress there.

emlun007 · 2017-11-06T07:13:10Z

@mterzo , The javascripts that I added were for another commit where I am trying to solve the issue with the table sorting, so I will just remove the parts of the code that are not related to save button

emlun007 · 2017-11-07T08:35:03Z

puppetboard/templates/layout.html

@@ -45,8 +47,9 @@
    <script src="{{ url_for('static', filename='js/scroll.top.js') }}"></script>
    <script src="{{url_for('static', filename='js/d3.min.js')}}"></script>
    <script src="{{url_for('static', filename='js/c3.min.js')}}"></script>
-    <script src="{{url_for('static',
-                  filename='jquery-tablesort-v.0.0.11/jquery.tablesort.min.js')}}"></script>


Lines 48 and 50 are identical. No changes

kirkins

I didn't test this code but here are a few NITs I'm seeing off the bat.

kirkins · 2017-11-28T13:56:58Z

puppetboard/templates/layout.html

@@ -2,7 +2,9 @@
 <html lang="en">
  <head>
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
-    <title>{{config.PAGE_TITLE}}</title>
+    <title>Puppetboard</title>


You shouldn't change this line in the commit

kirkins · 2017-11-28T13:57:53Z

puppetboard/templates/layout.html

@@ -2,7 +2,9 @@
 <html lang="en">
  <head>
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
-    <title>{{config.PAGE_TITLE}}</title>
+    <title>Puppetboard</title>
+    <button id="export" style="clear: right;width:127px;height:50px;color:#0a214a;box-shadow: 4px 4px #0a214a;margin-top: 5 px; margin-left: 5 px">Export data as csv</button>


You should move the inline style to the CSS block so it stays organized.

kirkins · 2017-11-28T15:50:23Z

puppetboard/templates/layout.html

+      var titles = [];
+      var data = [];
+
+  $('.dataTable th').each(function() {


Moving my comment about indentation, as this where you stopped indenting.

If line 67 is indented and no block has ended this should also be indented.

Also another small thing lines 66 and 67 should have a 2 space indent as children of the function starting on 65.

coveralls · 2017-12-08T08:54:30Z

Coverage remained the same at 81.76% when pulling ca7d238 on emlun007:master into c52f744 on voxpupuli:master.

coveralls · 2017-12-21T15:14:30Z

Coverage remained the same at 81.76% when pulling 868d11f on emlun007:master into c52f744 on voxpupuli:master.

kirkins · 2017-12-21T15:25:08Z

I see the button and when I press it a file downloads.

But the file is empty. I don't see any errors in the javascript console log.

Does the csv contain data on your setup?

kirkins · 2017-12-21T15:28:18Z

Other thoughts

Remove the favicon, it's cute but not related to this PR.
Nice job with the drop shadow but you will have to fix the design on this. I recommend integrating the button into the existing navigation bar.

Here is a preview of the button for those who haven't run the code locally:

emlun007 · 2017-12-21T15:29:46Z

The _macros.html is a different PR, same for favicon, I have no idea how the files got in this PR. The only change is in layout.html.

emlun007 · 2017-12-21T15:32:59Z

@kirkins , I updated layout.html with the version I am using. It works for chrome

coveralls · 2017-12-21T15:33:37Z

Coverage remained the same at 81.76% when pulling 4c57a22 on emlun007:master into c52f744 on voxpupuli:master.

kirkins · 2017-12-21T15:34:40Z

@emlun007 common mistake. You're using your master branch for this PR. That means the PR will reflect the state of your master branch.

Currently that branch has changes for multiple intended PRs.

You'll want to make a separate branch for each PR.

kirkins · 2017-12-21T15:44:21Z

puppetboard/templates/layout.html

+        var titles = [];
+        var data = [];
+
+        $('.dataTable th').each(function() {


The table doesn't have this class name on any of the pages I'm looking at.

What page did you test this on?

Ok I see it works perfect on the Inventory page.

Do you only intend to use it with inventory? Or do you want it to work on other pages too?

No, it works for all pages. I have tested on all facts, and it works there too

What is the browser? I have tested with IE and sometimes it doesn't work there

It seems to work on all fact pages for me too.

It doesn't work on Overview, Nodes, Facts, Reports, Metrics, Catalogs (kind of works), or Query.

This is because the data in Nodes,Facts ( try opening a fact, e.g. "ip adresses" there it works), reports is not initialized from dataTable, so there are no headers and data cells. So this code will only work on any data from dataTable

coveralls · 2017-12-21T15:48:11Z

Coverage remained the same at 81.76% when pulling fd32dca on emlun007:master into c52f744 on voxpupuli:master.

coveralls · 2017-12-21T15:48:12Z

Coverage remained the same at 81.76% when pulling f9edc83 on emlun007:master into c52f744 on voxpupuli:master.

kirkins · 2017-12-21T15:57:26Z

For style a better option might be just adding a CSV button to the menu:

<a id="export_data_button" class="item" href="#">CSV</a>

Then maybe add some logic to hide the button on pages it doesn't work with.

emlun007 · 2017-12-21T16:00:24Z

The thing is, I have many options now, like CSV, Excel, PDF, Copy, Print so CSV button is just one of the options.

I was thinking of disabling button if the cells are empty, so the button will be gray and the pointer changes to a cross. It is a nice feature, just takes time to write code

kirkins · 2017-12-21T16:05:34Z

I agree it is a nice feature. I don't think it can be released as is because people will see it on the first page, try, and think it's not working.

Also follow up on my menu suggestion. It might be a bit tricky because currently the menu is generated with:


      {%- for endpoint, caption in [
      ('index', 'Overview'),
      ('nodes', 'Nodes'),
      ('facts', 'Facts'),
      ('reports', 'Reports'),
      ('metrics', 'Metrics'),
      ('inventory', 'Inventory'),
      ('catalogs', 'Catalogs'),
      ('radiator', 'Radiator'),
      ('query', 'Query'),
] %}

Which doesn't seem to be able to take a value like ('#', 'CSV'), and has no room for the custom id.

emlun007 · 2017-12-22T06:51:56Z

I have tried to modify default_settings.py that defines the menu, but if you use anything else than 'fact name', 'fact', it gives 505 error so I don't think you can change the menu structure.

The button should work on the all th and td rows. The table uses .dataTable th and .dataTable td as input and it might be the case for facts, but I am unsure how nodes table is populated. I'm not too good with template engines so any help is appreciated.

gdubicki · 2022-02-22T09:25:03Z

Are you interested in getting back to this PR, rebasing and making it work @emlun007?

emlun007 added 2 commits October 19, 2017 15:40

Merge pull request #1 from emlun007/emlun007-button-csv

8d2745d

WIP: button for exporting tables as csv

larsnaesbye mentioned this pull request Oct 24, 2017

Export buttons for tables #428

Open

emlun007 added 2 commits October 25, 2017 15:17

Add files via upload

d6ca8e1

Button for export finally works

63816af

Button for export finally works

Add files via upload

a68c855

emlun007 commented Nov 7, 2017

View reviewed changes

emlun007 changed the title ~~WIP: button for exporting tables as csv~~ Button for exporting tables as csv Nov 7, 2017

Update layout.html

c34a858

kirkins reviewed Nov 28, 2017

View reviewed changes

emlun007 added 2 commits November 30, 2017 11:01

Update layout.html

fc0c9a0

Add files via upload

ca7d238

emlun007 mentioned this pull request Dec 21, 2017

Next release version #426

Closed

Add files via upload

868d11f

Update layout.html

4c57a22

kirkins reviewed Dec 21, 2017

View reviewed changes

Update _macros.html

fd32dca

Update _macros.html

f9edc83

gdubicki added the needs-rebase label Mar 31, 2021

gdubicki mentioned this pull request Dec 28, 2021

Add friendly message for invalid query and 0 results #653

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Button for exporting tables as csv #429

Button for exporting tables as csv #429

emlun007 commented Oct 19, 2017 •

edited by gdubicki

Loading

larsnaesbye commented Oct 30, 2017

mterzo commented Oct 30, 2017

emlun007 commented Nov 6, 2017

emlun007 Nov 7, 2017

kirkins left a comment •

edited

Loading

kirkins Nov 28, 2017

kirkins Nov 28, 2017

kirkins Nov 28, 2017

coveralls commented Dec 8, 2017 •

edited

Loading

coveralls commented Dec 21, 2017 •

edited

Loading

kirkins commented Dec 21, 2017

kirkins commented Dec 21, 2017

emlun007 commented Dec 21, 2017

emlun007 commented Dec 21, 2017

coveralls commented Dec 21, 2017 •

edited

Loading

kirkins commented Dec 21, 2017

kirkins Dec 21, 2017

kirkins Dec 21, 2017

emlun007 Dec 21, 2017

emlun007 Dec 21, 2017

kirkins Dec 21, 2017

emlun007 Dec 21, 2017

coveralls commented Dec 21, 2017

coveralls commented Dec 21, 2017 •

edited

Loading

kirkins commented Dec 21, 2017

emlun007 commented Dec 21, 2017

kirkins commented Dec 21, 2017 •

edited

Loading

emlun007 commented Dec 22, 2017

gdubicki commented Feb 22, 2022

Button for exporting tables as csv #429

Are you sure you want to change the base?

Button for exporting tables as csv #429

Conversation

emlun007 commented Oct 19, 2017 • edited by gdubicki Loading

larsnaesbye commented Oct 30, 2017

mterzo commented Oct 30, 2017

emlun007 commented Nov 6, 2017

Choose a reason for hiding this comment

kirkins left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 8, 2017 • edited Loading

coveralls commented Dec 21, 2017 • edited Loading

kirkins commented Dec 21, 2017

kirkins commented Dec 21, 2017

emlun007 commented Dec 21, 2017

emlun007 commented Dec 21, 2017

coveralls commented Dec 21, 2017 • edited Loading

kirkins commented Dec 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 21, 2017

coveralls commented Dec 21, 2017 • edited Loading

kirkins commented Dec 21, 2017

emlun007 commented Dec 21, 2017

kirkins commented Dec 21, 2017 • edited Loading

emlun007 commented Dec 22, 2017

gdubicki commented Feb 22, 2022

emlun007 commented Oct 19, 2017 •

edited by gdubicki

Loading

kirkins left a comment •

edited

Loading

coveralls commented Dec 8, 2017 •

edited

Loading

coveralls commented Dec 21, 2017 •

edited

Loading

coveralls commented Dec 21, 2017 •

edited

Loading

coveralls commented Dec 21, 2017 •

edited

Loading

kirkins commented Dec 21, 2017 •

edited

Loading