Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wpc integrationtest #168

Merged
merged 4 commits into from
Nov 18, 2019
Merged

Feature/wpc integrationtest #168

merged 4 commits into from
Nov 18, 2019

Conversation

neophob
Copy link
Contributor

@neophob neophob commented Nov 18, 2019

@neophob neophob requested a review from freezy November 18, 2019 20:32
@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #168 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #168     +/-   ##
========================================
+ Coverage    90.8%   90.9%   +0.1%     
========================================
  Files         272     272             
  Lines       14311   14312      +1     
  Branches     1671    1671             
========================================
+ Hits        12988   12996      +8     
+ Misses        820     814      -6     
+ Partials      503     502      -1
Impacted Files Coverage Δ
lib/emu/emulator-state.ts 89.4% <ø> (ø) ⬆️
lib/scripting/objects/vpm-controller.ts 89.5% <100%> (+0.1%) ⬆️
lib/vpt/ball/ball-hit.ts 77.5% <0%> (+0.9%) ⬆️
lib/physics/line-seg.ts 94.2% <0%> (+2.4%) ⬆️
lib/physics/hit-line-z.ts 88.9% <0%> (+4.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812d4fe...bd49332. Read the comment docs.

Copy link
Member

@freezy freezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😎

@freezy freezy merged commit 2115b7e into master Nov 18, 2019
@freezy freezy deleted the feature/wpc-integrationtest branch November 18, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants