Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libzedmd 0.9.1 #57

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

libzedmd 0.9.1 #57

wants to merge 4 commits into from

Conversation

mkalkbrenner
Copy link
Collaborator

@mkalkbrenner mkalkbrenner commented Feb 4, 2025

  • use cargs and FrameUtil from libzedmd
  • no cargs for android and iOS required
  • removed RGBOrder config for ZeDMD and the possibility to save settings. Meanwhile, ZeDMD has a settings menu, an embedded webserver and a command line client with way more settings to be managed. Just keep the brightness setting to allow an overwrite per game.

@jsm174
Copy link
Collaborator

jsm174 commented Feb 4, 2025

This seems to tie libdmdutil specifically to libzedmd. If there ever was a day someone wanted to build libdmdutil without zedmd support, they wouldn't be able to. I know highly unlikely, but just talking out loud.

@jsm174 jsm174 self-requested a review February 4, 2025 12:17
@mkalkbrenner
Copy link
Collaborator Author

This seems to tie libdmdutil specifically to libzedmd. If there ever was a day someone wanted to build libdmdutil without zedmd support, they wouldn't be able to. I know highly unlikely, but just talking out loud.

I thought about that as well. But I just continued the path we already took.
This way, compiling will be a bit faster and we can't run into a situation with conflicting SHAs.
And I think that ZeDMD should be always included as only device that is entirely open source.
If required, the libs could easily be moved back to libdmdutil. But for systems like batocera with a real dependency management, building these libs won't belong to lidmdutil or libzedmd, regardless of the build scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants