fix(tracker): ReadInstrument forgot to close the file

vsariola · Jan 25, 2025 · 5ee7e44 · 5ee7e44
1 parent dd7b5dd
commit 5ee7e44
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -45,6 +45,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
   be computed every draw. ([#176][i176])
 
 ### Fixed
+- Loading instrument forgot to close the file (in model.ReadInstrument)
 - We try to honor the MIDI event time stamps, so that the timing between MIDI
   events (as reported to us by RTMIDI) will be correct.
 - When unmarshaling the recovery file, the unit parameter maps were "merged"

diff --git a/tracker/files.go b/tracker/files.go
@@ -136,6 +136,7 @@ func (m *Model) LoadInstrument(r io.ReadCloser) bool {
 	if err != nil {
 		return false
 	}
+	r.Close() // if we can't close the file, it's not a big deal, so ignore the error
 	var instrument sointu.Instrument
 	var errJSON, errYaml, err4ki, err4kp error
 	var patch sointu.Patch