New billing cloud #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
reviewed
Nov 29, 2023
| @@ -17,7 +17,6 @@ See the [component documentation](https://hub.syn.tools/billing-collector-clouds | |||
| ## Getting started for developers | |||
|
|
|||
| In order to run this tool, you need | |||
| * An instance of the billing database | |||
There was a problem hiding this comment.
I guess we would need some Odoo16 endpoint somewhere?
But on the other hand we could probably have a small go tool that would just print all JSON that get posted to it to act as a mock endpoint.
zugao
force-pushed
the
new-billing-cloud
branch
5 times, most recently
from
7ddb29b to
4fb4f61
Compare
TheBigLee
force-pushed
the
new-billing-cloud
branch
2 times, most recently
from
4322919 to
fcd0672
Compare
Kidswiss
approved these changes
Dec 15, 2023
| collectInterval = 23 | ||
| } | ||
|
|
||
| wg.Add(1) |
There was a problem hiding this comment.
Just an idea for the future: we could change this to a select statement and use tickers. This way we could also integrate proper kill signal handling to exit the loop.
Kidswiss
requested changes
Dec 18, 2023
Kidswiss
approved these changes
Dec 18, 2023
TheBigLee
force-pushed
the
new-billing-cloud
branch
from
d3dc9e6 to
d654495
Compare
This commit removes any integration with the billing database. The metrics will be provided via an exporter. This integrates more nicely with the rest of the billing system. Metrics that are provided once a day, like for object storage, are only scraped after a specified time. Then the value will be divided by the rest of hours for the given day. Exoscale DBaaS metrics are provided as is. The metrics exported have the name `appcat:raw:billing` as they can't be used directly for the billing. A set of prometheus rules will do some aggregation and properly export them as `appcat:billing`. These rules are part of the component and not included in this commit.
TheBigLee
force-pushed
the
new-billing-cloud
branch
9 times, most recently
from
42398b8 to
44b9cd6
Compare
added 3 commits
December 19, 2023 16:01
Signed-off-by: Nicolas Bigler <[email protected]>
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
new-billing-cloud
branch
from
0ce3089 to
aa031d8
Compare
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
new-billing-cloud
branch
2 times, most recently
from
92af2ee to
16133f2
Compare
Signed-off-by: Nicolas Bigler <[email protected]>
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
new-billing-cloud
branch
from
16133f2 to
5f447cd
Compare
Kidswiss
requested changes
Dec 20, 2023
TheBigLee
force-pushed
the
new-billing-cloud
branch
2 times, most recently
from
155fd38 to
f918e63
Compare
Signed-off-by: Nicolas Bigler <[email protected]>
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
new-billing-cloud
branch
from
d710e80 to
066d295
Compare
Kidswiss
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the way we bill our cloud services.
Instead of writing our billing metrics to a billing database, we now export the billing metrics directly into our Odoo.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.