Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for k8ify.imagePullSecret label #153

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

martini-source
Copy link
Member

@martini-source martini-source commented Nov 18, 2024

Summary

Adds support for imagePullSecret configuration:

  • Create imagePullSecret secret from environment variable
  • Add imagePull secret to POD specifications

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@martini-source martini-source added the enhancement New feature or request label Nov 18, 2024
@martini-source martini-source self-assigned this Nov 18, 2024
README.md Outdated Show resolved Hide resolved
@davidgubler
Copy link
Member

Apart from these superficial issues I don't have any complaints, seems all reasonable.

@martini-source martini-source merged commit fa87641 into master Nov 19, 2024
4 checks passed
@martini-source martini-source deleted the feat/pullSecret branch November 19, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants