Skip to content

Commit

Permalink
Fix potential buffer overflow in Mod_LoadAliasFrame
Browse files Browse the repository at this point in the history
e.g. frame #1 (`Extend Tentacles`) of `progs/tarbaby.mdl`
from LibreQuake (https://github.com/MissLavender-LQ/LibreQuake/blob/bbe8e5a0850600ba774a34d5ba58817c2fd460f6/lq1/progs/tarbaby.mdl)
doesn't contain a NUL terminator.
  • Loading branch information
andrei-drexler authored and vsonnier committed Mar 9, 2024
1 parent 4633a8b commit bbd926e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Quake/gl_model.c
Original file line number Diff line number Diff line change
Expand Up @@ -2743,7 +2743,7 @@ void *Mod_LoadAliasFrame (void *pin, aliashdr_t *pheader, const int index)

pdaliasframe = (daliasframe_t *)pin;

strcpy (frame->name, pdaliasframe->name);
q_strlcpy (frame->name, pdaliasframe->name, sizeof (frame->name));
frame->firstpose = posenum;
frame->numposes = 1;

Expand Down

0 comments on commit bbd926e

Please sign in to comment.