Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove checkPermissions from metrics #43

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

Rudge
Copy link
Contributor

@Rudge Rudge commented Nov 9, 2023

What problem is this solving?

We are exceeding the limit of calls from the app to VBase. It is because we are using checkPermission to get the role and all permissions of the user, and this function calls any others that save data in VBase.

How to test it?

  • Call the operation using the directive @auditAccess

Workspace

- It calls the saveRole and saveJson in VBase
Copy link

vtex-io-ci-cd bot commented Nov 9, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Nov 9, 2023

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 4, PR deletions = 24

Generated by 🚫 dangerJS against 37e0855

@Rudge Rudge force-pushed the hotfix/B2BTEAM-1487-remove-getRoles-from-metrics branch from a741082 to 37e0855 Compare November 9, 2023 13:08
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Rudge Rudge requested a review from a team November 9, 2023 13:10
@Rudge Rudge merged commit bdb93fd into master Nov 9, 2023
10 checks passed
@Rudge Rudge deleted the hotfix/B2BTEAM-1487-remove-getRoles-from-metrics branch November 9, 2023 13:22
Copy link

vtex-io-ci-cd bot commented Nov 9, 2023

Your PR has been merged! App is being published. 🚀
Version 2.4.0 → 2.4.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants