-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: policy and token checkout integration #46
fix: policy and token checkout integration #46
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@@ -346,7 +346,7 @@ export const Mutation = { | |||
const { | |||
clients: { masterdata, hub }, | |||
vtex, | |||
vtex: { account, logger, storeUserAuthToken }, | |||
vtex: { account, logger, authToken }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between authToken
and storeUserAuthToken
? I'm afraid this change could break some use case that uses storeUserAuthToken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main differences are here. If we use the store token, we need to give this permission to all shoppers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I think I got it. We are using the app token to communicate with checkout (instead of the user token), which in this case seems to make sense (due to the permission issue you mentioned)
@@ -346,7 +346,7 @@ export const Mutation = { | |||
const { | |||
clients: { masterdata, hub }, | |||
vtex, | |||
vtex: { account, logger, storeUserAuthToken }, | |||
vtex: { account, logger, authToken }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I think I got it. We are using the app token to communicate with checkout (instead of the user token), which in this case seems to make sense (due to the permission issue you mentioned)
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
When the user uses the quote, there is an error and the price of the quote isn't set in the cart.
How to test it?
Use this quote https://revendapjba.ferimport.com.br/b2b-quotes/6ace0564-b175-11ee-8452-12c497aaea6f?workspace=usequote
Workspace
Screenshots or example usage: