Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set viewedByCustomer value correctly on quote creation #52

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

enzomerca
Copy link
Contributor

@enzomerca enzomerca commented Sep 3, 2024

What problem is this solving?

The sendToSalesRep input was being used to set the value for viewedByCustomer on quote creation, but if sendToSalesRep was not provided, viewedByCustomer would end up with a null value, causing an error on quote expiration while writing to master data.

This fix will set viewedByCustomer value to false if sendToSalesRep is not provided on quote creation.

@enzomerca enzomerca requested a review from a team September 3, 2024 18:21
Copy link

vtex-io-ci-cd bot commented Sep 3, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 3, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Sep 3, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 4, PR deletions = 1

Generated by 🚫 dangerJS against f1808cd

@enzomerca enzomerca changed the title fix: set viewedByCustomer value corectly on quote creation fix: set viewedByCustomer value correctly on quote creation Sep 4, 2024
Copy link

sonarqubecloud bot commented Sep 4, 2024

@enzomerca enzomerca merged commit d37be01 into master Sep 9, 2024
12 checks passed
@enzomerca enzomerca deleted the B2BTEAM-1866-fix-quote-expired-error branch September 9, 2024 11:52
Copy link

vtex-io-ci-cd bot commented Sep 9, 2024

Your PR has been merged! App is being published. 🚀
Version 2.6.0 → 2.6.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants