Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seller Quotes] feat: endpoint to save a seller quote #62

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

tiago-freire
Copy link

What problem is this solving?

Provides a route /b2b-quotes-graphql/_v/0/save-seller-quote/:seller/:id for seller save a quote at marketplace.

How to test it?

  • Link this branch on account bravtexfashionb2b in workspace b2bsellerquoteslocalhost
  • Link branch feat/save-seller-quotes of b2b-seller-quotes app on account shopfashion568 in workspace b2bsellerquoteslocalhost (the same workspace name)
  • Search documents of b2b_seller_quote entity of b2b-seller-quotes app to view your quotes
  • Run mutation saveSellerQuote implemented at branch feat/save-seller-quotes of b2b-seller-quotes with the id retrieved at search documents, some note, and a empty array for items (just for test).

Workspace

brunass and others added 30 commits November 26, 2024 14:09
…tex/b2b-quotes-graphql into feat/splitting-quote-by-seller
…x/b2b-quotes-graphql into feat/notify-seller-quote
…tex/b2b-quotes-graphql into feat/notify-seller-quote
…quotes-graphql into feat/notify-seller-quote
Copy link

vtex-io-ci-cd bot commented Dec 20, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@tiago-freire tiago-freire changed the title [Seller Quotes] Endpoint to save a seller quote [Seller Quotes] feat: endpoint to save a seller quote Dec 21, 2024
Copy link
Contributor

@Matheus-Aguilar Matheus-Aguilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are creating a new method to save seller quotes and we are going to keep it this way for now. But since seller quotes have the same structure and entity as regular quotes, we should change it in the future to use the updateQuote method avoiding code duplication.

Copy link

github-actions bot commented Jan 8, 2025

Warnings
⚠️

Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 785, PR deletions = 106

Generated by 🚫 dangerJS against 725afaf

Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants