[Seller Quotes] feat: quote new fields and create children quote for marketplace when splitted if necessary #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add new markeplace splitting quotes on graphql * feat: checking new field quotesManagedBy when value is SELLER * docs: update CHANGELOG * feat: add configuration for quote creation * feat: add adjustment for quote seller * chore: fix prettier errors * fix: returning ids separated by commas when multiple quotes * fix: check config and default settings with marketplace option * feat: new fields for quotes managed by seller * feat: new fields to save parent quote; change getQuotes query to filter only parent quotes * feat: create client to notify seller quote * feat: add changelog * feat: verify and notify seller quote * chore: removes console.log from SellerQuotesClient * docs: update CHANGELOG and prettier fix on markdown * fix: right splitting of seller quotes * feat: refactor on creating seller quote map; avoid double check of seller * refactor: seller quotes client constants * feat: send creationDate on notify seller quote * feat: provides a route for seller get a quote by id at marketplace * docs: update CHANGELOG * refactor: separating get seller quote into smaller functions * refactor: function to get org anc cost center names * refactor: create service class for seller quotes * fix: removing approvedBySeller field from quote entity * refactor: renaming seller quotes service to controller * feat: get seller quotes paginated * feat: use seller quote controller * docs: add changelog * chore: fix misspell * fix: use array destructuring * fix: sorting get seller quotes for right pagination * feat: supporting search and status filters on get seller quotes * feat: using search filter on quote creator email * fix: right dependencies * fix: remove p-limit from root package.json * feat: suport for custom sort and where on ger seller quotes paginated * [Seller Quotes] Add new markeplace splitting quotes on graphql (vtex-apps#57) * feat: add new markeplace splitting quotes on graphql * docs: update CHANGELOG * chore: fix prettier errors * fix: check config and default settings with marketplace option * docs: update CHANGELOG and prettier fix on markdown --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: BrunaCubos <[email protected]>
* feat: add new markeplace splitting quotes on graphql * feat: checking new field quotesManagedBy when value is SELLER * docs: update CHANGELOG * feat: add configuration for quote creation * feat: add adjustment for quote seller * chore: fix prettier errors * fix: returning ids separated by commas when multiple quotes * fix: check config and default settings with marketplace option * feat: new fields for quotes managed by seller * feat: new fields to save parent quote; change getQuotes query to filter only parent quotes * feat: create client to notify seller quote * feat: add changelog * feat: verify and notify seller quote * chore: removes console.log from SellerQuotesClient * docs: update CHANGELOG and prettier fix on markdown * fix: right splitting of seller quotes * feat: refactor on creating seller quote map; avoid double check of seller * refactor: seller quotes client constants * feat: send creationDate on notify seller quote * feat: provides a route for seller get a quote by id at marketplace * docs: update CHANGELOG * refactor: separating get seller quote into smaller functions * refactor: function to get org anc cost center names * refactor: create service class for seller quotes * fix: removing approvedBySeller field from quote entity * refactor: renaming seller quotes service to controller * feat: provides a route for seller save a quote at marketplace * feat: get seller quotes paginated * feat: use seller quote controller * docs: add changelog * chore: fix misspell * fix: use array destructuring * fix: sorting get seller quotes for right pagination * feat: supporting search and status filters on get seller quotes * feat: using search filter on quote creator email * fix: right dependencies * fix: remove p-limit from root package.json * feat: suport for custom sort and where on ger seller quotes paginated * [Seller Quotes] Add new markeplace splitting quotes on graphql (vtex-apps#57) * feat: add new markeplace splitting quotes on graphql * docs: update CHANGELOG * chore: fix prettier errors * fix: check config and default settings with marketplace option * docs: update CHANGELOG and prettier fix on markdown --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Guido Bernal <[email protected]> Co-authored-by: BrunaCubos <[email protected]>
* feat: add new markeplace splitting quotes on graphql * feat: checking new field quotesManagedBy when value is SELLER * docs: update CHANGELOG * feat: add configuration for quote creation * feat: add adjustment for quote seller * chore: fix prettier errors * fix: returning ids separated by commas when multiple quotes * fix: check config and default settings with marketplace option * feat: new fields for quotes managed by seller * feat: new fields to save parent quote; change getQuotes query to filter only parent quotes * feat: create client to notify seller quote * feat: add changelog * feat: verify and notify seller quote * chore: removes console.log from SellerQuotesClient * docs: update CHANGELOG and prettier fix on markdown * fix: right splitting of seller quotes * feat: refactor on creating seller quote map; avoid double check of seller * refactor: seller quotes client constants * feat: send creationDate on notify seller quote * feat: provides a route for seller get a quote by id at marketplace * docs: update CHANGELOG * refactor: separating get seller quote into smaller functions * refactor: function to get org anc cost center names * refactor: create service class for seller quotes * fix: removing approvedBySeller field from quote entity * refactor: renaming seller quotes service to controller * feat: provides a route for seller save a quote at marketplace * feat: get seller quotes paginated * feat: use seller quote controller * docs: add changelog * chore: fix misspell * fix: use array destructuring * fix: sorting get seller quotes for right pagination * feat: supporting search and status filters on get seller quotes * feat: using search filter on quote creator email * feat: add split quote query * fix: right dependencies * fix: remove p-limit from root package.json * feat: suport for custom sort and where on ger seller quotes paginated * [Seller Quotes] Add new markeplace splitting quotes on graphql (vtex-apps#57) * feat: add new markeplace splitting quotes on graphql * docs: update CHANGELOG * chore: fix prettier errors * fix: check config and default settings with marketplace option * docs: update CHANGELOG and prettier fix on markdown --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Guido Bernal <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… feat/changes-on-seller-quotes
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
|
|
@Matheus-Aguilar peço para segurar um pouco a análise desse PR pois estamos fazendo mais algumas alterações. |
tiago-freire
changed the title
|
@Matheus-Aguilar, PR disponível para revisão. |
tiago-freire
changed the title
|
node/resolvers/mutations/index.ts
Outdated
| } | ||
|
|
||
| if (existingQuote.hasChildren && decline) { | ||
| const childrenQuotes = await sellerQuotesController.getAllChildrenQuotes( |
There was a problem hiding this comment.
Are we declining all children's quotes if the marketplace declines the parent quote? I'm not sure if this is the desired behavior since the seller is responsible for managing quotes.
There was a problem hiding this comment.
It makes perfect sense! Let's analyze the changes that will be needed.
There was a problem hiding this comment.
done at a5c77a0
Matheus-Aguilar
approved these changes
Jan 22, 2025
Matheus-Aguilar
changed the base branch from
master
to
feat/B2BTEAM-1998-b2b-seller-quotes
Matheus-Aguilar
merged commit 318ac3c
into
vtex-apps:feat/B2BTEAM-1998-b2b-seller-quotes
8 of 9 checks passed
Matheus-Aguilar
added a commit
that referenced
this pull request
Jan 23, 2025
#68) * [Seller Quotes] feat: quote new fields and create children quote for marketplace when splitted if necessary (#66) * [Seller Quotes] feat: get seller quotes paginated api (#61) * feat: add new markeplace splitting quotes on graphql * feat: checking new field quotesManagedBy when value is SELLER * docs: update CHANGELOG * feat: add configuration for quote creation * feat: add adjustment for quote seller * chore: fix prettier errors * fix: returning ids separated by commas when multiple quotes * fix: check config and default settings with marketplace option * feat: new fields for quotes managed by seller * feat: new fields to save parent quote; change getQuotes query to filter only parent quotes * feat: create client to notify seller quote * feat: add changelog * feat: verify and notify seller quote * chore: removes console.log from SellerQuotesClient * docs: update CHANGELOG and prettier fix on markdown * fix: right splitting of seller quotes * feat: refactor on creating seller quote map; avoid double check of seller * refactor: seller quotes client constants * feat: send creationDate on notify seller quote * feat: provides a route for seller get a quote by id at marketplace * docs: update CHANGELOG * refactor: separating get seller quote into smaller functions * refactor: function to get org anc cost center names * refactor: create service class for seller quotes * fix: removing approvedBySeller field from quote entity * refactor: renaming seller quotes service to controller * feat: get seller quotes paginated * feat: use seller quote controller * docs: add changelog * chore: fix misspell * fix: use array destructuring * fix: sorting get seller quotes for right pagination * feat: supporting search and status filters on get seller quotes * feat: using search filter on quote creator email * fix: right dependencies * fix: remove p-limit from root package.json * feat: suport for custom sort and where on ger seller quotes paginated * [Seller Quotes] Add new markeplace splitting quotes on graphql (#57) * feat: add new markeplace splitting quotes on graphql * docs: update CHANGELOG * chore: fix prettier errors * fix: check config and default settings with marketplace option * docs: update CHANGELOG and prettier fix on markdown --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: BrunaCubos <[email protected]> * [Seller Quotes] feat: endpoint to save a seller quote (#62) * feat: add new markeplace splitting quotes on graphql * feat: checking new field quotesManagedBy when value is SELLER * docs: update CHANGELOG * feat: add configuration for quote creation * feat: add adjustment for quote seller * chore: fix prettier errors * fix: returning ids separated by commas when multiple quotes * fix: check config and default settings with marketplace option * feat: new fields for quotes managed by seller * feat: new fields to save parent quote; change getQuotes query to filter only parent quotes * feat: create client to notify seller quote * feat: add changelog * feat: verify and notify seller quote * chore: removes console.log from SellerQuotesClient * docs: update CHANGELOG and prettier fix on markdown * fix: right splitting of seller quotes * feat: refactor on creating seller quote map; avoid double check of seller * refactor: seller quotes client constants * feat: send creationDate on notify seller quote * feat: provides a route for seller get a quote by id at marketplace * docs: update CHANGELOG * refactor: separating get seller quote into smaller functions * refactor: function to get org anc cost center names * refactor: create service class for seller quotes * fix: removing approvedBySeller field from quote entity * refactor: renaming seller quotes service to controller * feat: provides a route for seller save a quote at marketplace * feat: get seller quotes paginated * feat: use seller quote controller * docs: add changelog * chore: fix misspell * fix: use array destructuring * fix: sorting get seller quotes for right pagination * feat: supporting search and status filters on get seller quotes * feat: using search filter on quote creator email * fix: right dependencies * fix: remove p-limit from root package.json * feat: suport for custom sort and where on ger seller quotes paginated * [Seller Quotes] Add new markeplace splitting quotes on graphql (#57) * feat: add new markeplace splitting quotes on graphql * docs: update CHANGELOG * chore: fix prettier errors * fix: check config and default settings with marketplace option * docs: update CHANGELOG and prettier fix on markdown --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Guido Bernal <[email protected]> Co-authored-by: BrunaCubos <[email protected]> * [Seller Quotes] Add query for quote parent id (#63) * feat: add new markeplace splitting quotes on graphql * feat: checking new field quotesManagedBy when value is SELLER * docs: update CHANGELOG * feat: add configuration for quote creation * feat: add adjustment for quote seller * chore: fix prettier errors * fix: returning ids separated by commas when multiple quotes * fix: check config and default settings with marketplace option * feat: new fields for quotes managed by seller * feat: new fields to save parent quote; change getQuotes query to filter only parent quotes * feat: create client to notify seller quote * feat: add changelog * feat: verify and notify seller quote * chore: removes console.log from SellerQuotesClient * docs: update CHANGELOG and prettier fix on markdown * fix: right splitting of seller quotes * feat: refactor on creating seller quote map; avoid double check of seller * refactor: seller quotes client constants * feat: send creationDate on notify seller quote * feat: provides a route for seller get a quote by id at marketplace * docs: update CHANGELOG * refactor: separating get seller quote into smaller functions * refactor: function to get org anc cost center names * refactor: create service class for seller quotes * fix: removing approvedBySeller field from quote entity * refactor: renaming seller quotes service to controller * feat: provides a route for seller save a quote at marketplace * feat: get seller quotes paginated * feat: use seller quote controller * docs: add changelog * chore: fix misspell * fix: use array destructuring * fix: sorting get seller quotes for right pagination * feat: supporting search and status filters on get seller quotes * feat: using search filter on quote creator email * feat: add split quote query * fix: right dependencies * fix: remove p-limit from root package.json * feat: suport for custom sort and where on ger seller quotes paginated * [Seller Quotes] Add new markeplace splitting quotes on graphql (#57) * feat: add new markeplace splitting quotes on graphql * docs: update CHANGELOG * chore: fix prettier errors * fix: check config and default settings with marketplace option * docs: update CHANGELOG and prettier fix on markdown --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> --------- Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Tiago de Andrade Freire <[email protected]> Co-authored-by: Guido Bernal <[email protected]> * Fix code scanning alert no. 4: Incomplete string escaping or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * feat: new quote fields creatorName, sellerName and childrenQuantity * docs: update CHANGELOG * fix: update lastUpdate on handle parent quote status and subtotal * feat: creating parent quote only on multiple quotes; handling creatorName * feat: handling use, decline and place order of children quotes * fix: creatorName masterdata type * fix: seller quote only receive updates from your orders * feat: add query checkSellerQuotes; remove storeName setting; do not receive seller name * fix: remove declining children; seller quotes should be created with pending status --------- Co-authored-by: guidobernal-cubos <[email protected]> Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: BrunaCubos <[email protected]> Co-authored-by: Matheus-Aguilar <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * fix: fixing code smells * fix: fixing lint issues * fix: remove more code smells * fix: solve more sonarcloud issues --------- Co-authored-by: Tiago Freire <[email protected]> Co-authored-by: guidobernal-cubos <[email protected]> Co-authored-by: Bruna Santos <[email protected]> Co-authored-by: BrunaCubos <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
How to test it?
sellerName's andcreatorName'sWorkspace