-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route to return the rectification config value #678
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
2ec80ba
to
1233a85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Co-authored-by: Wagner Lemos Duarte <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
This pull request introduces a new feature to fetch email rectification configuration from the OMS service. The most important changes include adding a new method to the
OMS
client, updating the service configuration to include a new route, and implementing the route handler.We need this to make this route accessible only to authenticated shoppers using the application token to retrieve the configuration.
How to test it?
Workspace
New Feature: Email Rectification Configuration
node/clients/oms.ts
: Added a new methodgetRmailRetificationConfig
to fetch email rectification configuration from the OMS service.node/index.ts
: Imported the new route handlergetEmailRetificationConfig
and added a new routerectification-config
to the service configuration. [1] [2]node/routes/index.ts
: Implemented thegetEmailRetificationConfig
route handler to fetch and return the email rectification configuration, and added a helper functionsetForbiddenStatus
to handle authorization errors.node/service.json
: Updated the service configuration to include the new routerectification-config
with its path and access settings.