feat: Add New Icons #2288
Draft
feat: Add New Icons #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
renatamottam
force-pushed
the
feat/new-icons
branch
from
cd45a1c to
36f4de9
Compare
Should be used as reference
>⚠️ This PR is `in draft` because it is part of a standby feature, New Icons; we will return to it. - Replace Icon components declarations: - Renames `name` prop to add `fs-` prefix and convert to kebab-case - Removes `weight` prop if exists - Replaces `width` and `height` props with `size`. (Allowed size values: `20, 24, 32`. If the previous value is <= 20, the value will be 20, if the value is >= 32, the new value will be 32. Else, we don't need to add the size prop - the default value will be`24`. **Updates** - [x] faststore/components/atoms - [x] faststore/components/molecules - [x] faststore/components/organisms - [x] faststore/core - Core components - Icons in `sections.json` - Renames Envelop for `Envelop` -> fs-envelop **TO-DOs**: - [x] Renames PaymentMethods icons - [x] Renames Social icons - [ ] [Rating.tsx](#2292 (comment)) : We will have to fix this component and its SVG on another PR. <!--- Tell us the role of the new feature, or component, in its context. ---> <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> <!--- Add a link to a deploy preview from `gatsby.store` AND `nextjs.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Update Icons to Material Symbols](https://vtex-dev.atlassian.net/browse/SFS-760?atlOrigin=eyJpIjoiMzBkZThjZDYzMjkxNGUyZmFkNmY0MTI0NjU0OTVkNjkiLCJwIjoiaiJ9) --------- Co-authored-by: renatamottam <[email protected]> Co-authored-by: Renata Motta <[email protected]>
renatamottam
force-pushed
the
feat/new-icons
branch
from
9d99e4e to
8ecd18e
Compare
hellofanny
reviewed
Jan 16, 2025
| .replace(/\/([^\/]*)\//, '/$1-')}` | ||
| ) | ||
| } | ||
| // const { pathname } = new URL(request.url) |
There was a problem hiding this comment.
🎗️ TODO: uncomment this part when merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR updates our icon library to fit the new VTEX Design Foundation.
Activities
RatingcomponentFS Corestore icons chore: Replace icons props #2292For the Future
How it works?
For now, we're going to accept both symbol styles, but all new symbols added by us will be following the new pattern and the old will be deprecated eventually. Some important changes on the
Iconcomponent:sizeprop24height,widthandweightprops are now marked as deprecated (but it's still working)How to test it?
Our old doc is updated for testing and reviewing purposes: https://faststore-site-git-feat-new-icons-faststore.vercel.app/docs/icons