Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] chore: Replace isomorphic-unfetch with node-fetch #2562

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

lucasfp13
Copy link
Contributor

@lucasfp13 lucasfp13 commented Nov 14, 2024

What's the purpose of this pull request?

This PR intends to replace the isomorphic-unfetch lib with node-fetch towards supporting the use of Host header.

How it works?

Everything should work as before.

How to test it?

Check if all the requests are behaving correctly.

Starters Deploy Preview

vtex-sites/nextjs.store#414

@lucasfp13 lucasfp13 added the dependencies Pull requests that update a dependency file label Nov 14, 2024
@lucasfp13 lucasfp13 self-assigned this Nov 14, 2024
@lucasfp13 lucasfp13 requested a review from a team as a code owner November 14, 2024 14:58
@lucasfp13 lucasfp13 requested review from eduardoformiga and renatomaurovtex and removed request for a team November 14, 2024 14:58
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ❌ Failed (Inspect) Nov 14, 2024 2:58pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@lucasfp13 lucasfp13 changed the title chore: Replace isomorphic-unfetch with node-fetch [1.x] chore: Replace isomorphic-unfetch with node-fetch Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant