Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preact support for projects with legacy store config #2574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pedromtec
Copy link
Contributor

@pedromtec pedromtec commented Nov 25, 2024

What's the purpose of this pull request?

feat: add preact support for projects with legacy store config (faststore.config.js)

How it works?

I created a function that returns new (discovery.config.js) or legacy (faststore.config.js) store config file

How to test it?

Enable preact flag using faststore.config.js and discovery.config.js. Both should work.

Check the documentation for more details: https://developers.vtex.com/docs/guides/faststore/managing-performance-improving-store-performance-with-preact

Result

Captura de Tela 2024-11-26 às 09 54 16

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 8:21pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pedromtec pedromtec changed the title feat: add preact support for projects with legacy (faststore.config.j… feat: add preact support for projects with legacy store config Nov 26, 2024
@pedromtec pedromtec marked this pull request as ready for review November 26, 2024 12:57
@pedromtec pedromtec requested a review from a team as a code owner November 26, 2024 12:57
@pedromtec pedromtec requested review from eduardoformiga and renatomaurovtex and removed request for a team November 26, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants