Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): enhance reactive function to handle the WeakMap key #12824

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FatRadish
Copy link

close #12807

@FatRadish FatRadish closed this Feb 12, 2025
@edison1105 edison1105 reopened this Feb 12, 2025
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Feb 12, 2025
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38.1 kB (+4 B) 34.4 kB (+63 B)
vue.global.prod.js 158 kB 58 kB (+3 B) 51.6 kB (-38 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB (-1 B) 16.7 kB (-5 B)
createApp 54.6 kB 21.3 kB (+4 B) 19.4 kB (+6 B)
createSSRApp 58.8 kB 23 kB (-2 B) 21 kB (+39 B)
defineCustomElement 59.4 kB 22.9 kB (-2 B) 20.8 kB (+4 B)
overall 68.6 kB 26.4 kB (+3 B) 24 kB (+13 B)

Copy link

pkg-pr-new bot commented Feb 12, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12824

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12824

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12824

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12824

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12824

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12824

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12824

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12824

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12824

vue

npm i https://pkg.pr.new/vue@12824

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12824

commit: 3cb45eb

@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Feb 12, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why not Reorder getTargetType check after proxyMap lookup in createReactiveObject
3 participants