Skip to content

chore(core): improve type comments and replace internal with private #531

chore(core): improve type comments and replace internal with private

chore(core): improve type comments and replace internal with private #531

Triggered via push September 12, 2024 17:43
Status Success
Total duration 5m 56s
Artifacts

e2e.yml

on: push
Matrix: e2e
e2e result
0s
e2e result
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 72 notices
[chromium] β€Ί hmr.spec.ts:79:3 β€Ί should update title correctly: e2e/tests/hmr.spec.ts#L91
1) [chromium] β€Ί hmr.spec.ts:79:3 β€Ί should update title correctly ───────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toHaveTitle(expected) Locator: locator(':root') Expected pattern: /Updated Title/ Received string: "HMR Title | VuePress E2E" Call log: - expect.toHaveTitle with timeout 5000ms - waiting for locator(':root') - locator resolved to <html lang="en-US">…</html> - unexpected value "HMR Title | VuePress E2E" - locator resolved to <html lang="en-US">…</html> - unexpected value "HMR Title | VuePress E2E" - locator resolved to <html lang="en-US">…</html> - unexpected value "HMR Title | VuePress E2E" - locator resolved to <html lang="en-US">…</html> - unexpected value "HMR Title | VuePress E2E" - locator resolved to <html lang="en-US">…</html> - unexpected value "HMR Title | VuePress E2E" - locator resolved to <html lang="en-US">…</html> - unexpected value "HMR Title | VuePress E2E" - locator resolved to <html lang="en-US">…</html> - unexpected value "HMR Title | VuePress E2E" - locator resolved to <html lang="en-US">…</html> - unexpected value "HMR Title | VuePress E2E" - locator resolved to <html lang="en-US">…</html> - unexpected value "HMR Title | VuePress E2E" 89 | await expect(renderedTitleLocator).toHaveText('HMR Title') 90 | await hmrUpdateTitle() > 91 | await expect(page).toHaveTitle(/Updated Title/) | ^ 92 | await expect(titleLocator).toHaveText('Updated Title') 93 | await expect(renderedTitleLocator).toHaveText('Updated Title') 94 | }) at /Users/runner/work/core/core/e2e/tests/hmr.spec.ts:91:24
[chromium] β€Ί hmr.spec.ts:79:3 β€Ί should update title correctly: e2e/tests/hmr.spec.ts#L87
1) [chromium] β€Ί hmr.spec.ts:79:3 β€Ί should update title correctly ───────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toHaveTitle(expected) Locator: locator(':root') Expected pattern: /HMR Title/ Received string: "" Call log: - expect.toHaveTitle with timeout 5000ms - waiting for locator(':root') - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" 85 | await page.goto('hmr/title.html') 86 | > 87 | await expect(page).toHaveTitle(/HMR Title/) | ^ 88 | await expect(titleLocator).toHaveText('HMR Title') 89 | await expect(renderedTitleLocator).toHaveText('HMR Title') 90 | await hmrUpdateTitle() at /Users/runner/work/core/core/e2e/tests/hmr.spec.ts:87:24
[chromium] β€Ί hmr.spec.ts:96:3 β€Ί should update content and frontmatter and title correctly after navigation: e2e/tests/hmr.spec.ts#L122
2) [chromium] β€Ί hmr.spec.ts:96:3 β€Ί should update content and frontmatter and title correctly after navigation Error: Timed out 5000ms waiting for expect(locator).toHaveTitle(expected) Locator: locator(':root') Expected pattern: /HMR Title/ Received string: "" Call log: - expect.toHaveTitle with timeout 5000ms - waiting for locator(':root') - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" - locator resolved to <html lang="en">…</html> - unexpected value "" 120 | // start from title page 121 | await page.goto('hmr/title.html') > 122 | await expect(page).toHaveTitle(/HMR Title/) | ^ 123 | await expect(titleLocator).toHaveText('HMR Title') 124 | await expect(renderedTitleLocator).toHaveText('HMR Title') 125 | at /Users/runner/work/core/core/e2e/tests/hmr.spec.ts:122:24
[chromium] β€Ί router\navigate-by-router.spec.ts:26:1 β€Ί should preserve query and hash: e2e\tests\router\navigate-by-router.spec.ts#L28
1) [chromium] β€Ί router\navigate-by-router.spec.ts:26:1 β€Ί should preserve query and hash ────────── Error: Timed out 5000ms waiting for expect(locator).toHaveURL(expected) Locator: locator(':root') Expected string: "http://127.0.0.1:9080/e2e/?home=true#home" Received string: "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" Call log: - expect.toHaveURL with timeout 5000ms - waiting for locator(':root') - locator resolved to <html lang="en-US">…</html> - unexpected value "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" - locator resolved to <html lang="en-US">…</html> - unexpected value "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" - locator resolved to <html lang="en-US">…</html> - unexpected value "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" - locator resolved to <html lang="en-US">…</html> - unexpected value "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" - locator resolved to <html lang="en-US">…</html> - unexpected value "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" - locator resolved to <html lang="en-US">…</html> - unexpected value "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" - locator resolved to <html lang="en-US">…</html> - unexpected value "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" - locator resolved to <html lang="en-US">…</html> - unexpected value "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" - locator resolved to <html lang="en-US">…</html> - unexpected value "http://127.0.0.1:9080/e2e/router/navigate-by-router.html" 26 | test('should preserve query and hash', async ({ page }) => { 27 | await page.locator('#home-with-query-and-hash').click() > 28 | await expect(page).toHaveURL(`${BASE}?home=true#home`) | ^ 29 | await expect(page.locator('#home-h2')).toHaveText('Home H2') 30 | }) 31 | at D:\a\core\core\e2e\tests\router\navigate-by-router.spec.ts:28:22
🎭 Playwright Run Summary
71 passed (21.1s)
🎭 Playwright Run Summary
67 passed (15.2s)
🎭 Playwright Run Summary
71 passed (22.6s)
🎭 Playwright Run Summary
67 passed (16.0s)
🎭 Playwright Run Summary
71 passed (22.3s)
🎭 Playwright Run Summary
67 passed (15.6s)
🎭 Playwright Run Summary
71 passed (22.6s)
🎭 Playwright Run Summary
67 passed (15.1s)
🎭 Playwright Run Summary
71 passed (21.4s)
🎭 Playwright Run Summary
67 passed (16.5s)
🎭 Playwright Run Summary
71 passed (21.7s)
🎭 Playwright Run Summary
67 passed (16.6s)
🎭 Playwright Run Summary
71 passed (21.6s)
🎭 Playwright Run Summary
67 passed (17.1s)
🎭 Playwright Run Summary
71 passed (21.9s)
🎭 Playwright Run Summary
67 passed (17.1s)
🎭 Playwright Run Summary
71 passed (22.2s)
🎭 Playwright Run Summary
67 passed (15.6s)
🎭 Playwright Run Summary
71 passed (21.4s)
🎭 Playwright Run Summary
67 passed (15.7s)
🎭 Playwright Run Summary
71 passed (32.9s)
🎭 Playwright Run Summary
67 passed (25.4s)
🎭 Playwright Run Summary
71 passed (31.5s)
🎭 Playwright Run Summary
67 passed (26.3s)
🎭 Playwright Run Summary
71 passed (30.3s)
🎭 Playwright Run Summary
67 passed (24.3s)
🎭 Playwright Run Summary
71 passed (32.8s)
🎭 Playwright Run Summary
67 passed (24.9s)
🎭 Playwright Run Summary
71 passed (32.0s)
🎭 Playwright Run Summary
67 passed (25.8s)
🎭 Playwright Run Summary
71 passed (33.4s)
🎭 Playwright Run Summary
67 passed (25.8s)
🎭 Playwright Run Summary
71 passed (30.4s)
🎭 Playwright Run Summary
67 passed (22.0s)
🎭 Playwright Run Summary
71 passed (26.1s)
🎭 Playwright Run Summary
67 passed (22.8s)
🎭 Playwright Run Summary
71 passed (26.4s)
🎭 Playwright Run Summary
67 passed (20.6s)
🎭 Playwright Run Summary
71 passed (35.3s)
🎭 Playwright Run Summary
67 passed (21.6s)
🎭 Playwright Run Summary
71 passed (29.6s)
🎭 Playwright Run Summary
67 passed (23.4s)
🎭 Playwright Run Summary
71 passed (33.7s)
🎭 Playwright Run Summary
67 passed (23.5s)
🎭 Playwright Run Summary
1 flaky [chromium] β€Ί hmr.spec.ts:79:3 β€Ί should update title correctly ────────────────────────────────── 70 passed (28.9s)
🎭 Playwright Run Summary
67 passed (16.7s)
🎭 Playwright Run Summary
2 flaky [chromium] β€Ί hmr.spec.ts:79:3 β€Ί should update title correctly ────────────────────────────────── [chromium] β€Ί hmr.spec.ts:96:3 β€Ί should update content and frontmatter and title correctly after navigation 69 passed (38.7s)
🎭 Playwright Run Summary
67 passed (18.9s)
🎭 Playwright Run Summary
71 passed (24.6s)
🎭 Playwright Run Summary
67 passed (20.1s)
🎭 Playwright Run Summary
71 passed (31.1s)
🎭 Playwright Run Summary
67 passed (20.9s)
🎭 Playwright Run Summary
71 passed (37.1s)
🎭 Playwright Run Summary
67 passed (22.3s)
🎭 Playwright Run Summary
71 passed (29.6s)
🎭 Playwright Run Summary
67 passed (23.2s)
🎭 Playwright Run Summary
71 passed (47.0s)
🎭 Playwright Run Summary
67 passed (39.1s)
🎭 Playwright Run Summary
71 passed (52.6s)
🎭 Playwright Run Summary
67 passed (40.1s)
🎭 Playwright Run Summary
71 passed (31.8s)
🎭 Playwright Run Summary
67 passed (21.3s)
🎭 Playwright Run Summary
71 passed (27.9s)
🎭 Playwright Run Summary
1 flaky [chromium] β€Ί router\navigate-by-router.spec.ts:26:1 β€Ί should preserve query and hash ─────────── 66 passed (23.9s)
🎭 Playwright Run Summary
71 passed (44.3s)
🎭 Playwright Run Summary
67 passed (36.0s)
🎭 Playwright Run Summary
71 passed (43.6s)
🎭 Playwright Run Summary
67 passed (36.1s)
🎭 Playwright Run Summary
71 passed (42.6s)
🎭 Playwright Run Summary
67 passed (34.5s)
🎭 Playwright Run Summary
71 passed (43.5s)
🎭 Playwright Run Summary
67 passed (34.4s)