Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VChip): apply size styles #19374

Closed
wants to merge 1 commit into from
Closed

Conversation

SonTT19
Copy link
Contributor

@SonTT19 SonTT19 commented Mar 12, 2024

Description

fixes #19356

Markup:

<template>
  <v-app>
    <v-container>
      <v-chip size="100">hello</v-chip>
      <v-chip>hello</v-chip>
    </v-container>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const msg = ref('Hello World!')
</script>

@KaelWD
Copy link
Member

KaelWD commented Mar 12, 2024

useSize sets both width and height to the same value, chip sizes need to go through these mixins instead: https://github.com/vuetifyjs/vuetify/blob/d8fd2297d04b130a484b723aa9c21dff7546c9a1/packages/vuetify/src/components/VChip/_mixins.scss

@SonTT19
Copy link
Contributor Author

SonTT19 commented Mar 12, 2024

useSize sets both width and height to the same value, chip sizes need to go through these mixins instead: https://github.com/vuetifyjs/vuetify/blob/d8fd2297d04b130a484b723aa9c21dff7546c9a1/packages/vuetify/src/components/VChip/_mixins.scss

Thanks @KaelWD for the review. But i'm not sure how can it be done in this case.
If you can enlighten me, that would be great. Otherwise i might close this PR

@KaelWD
Copy link
Member

KaelWD commented Mar 12, 2024

This is similar to #16288

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VChip labels Mar 12, 2024
@johnleider
Copy link
Member

Instead of sizeStyles you should useDimensions from the dimensions composable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VChip S: stale This issue is untriaged and hasn't seen any activity in at least six months. T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.5.8] v-chip size attribute do not set height
4 participants