Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useScroll): use mutationObserver to update arrivedState when the DOM is changed #4269

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andylou0102
Copy link

@andylou0102 andylou0102 commented Oct 6, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

close #4265

Additional context

My test below ( forked from haykkh )

https://stackblitz.com/edit/vitejs-vite-vthxo9?file=src%2FuseScrollTest.js

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 6, 2024
@andylou0102 andylou0102 changed the title Fix/add mutation observer in use scroll fix(useScroll): use mutationObserver to update arrivedState when the DOM is changed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useScroll's arrivedState not responsive to changes in DOM
1 participant