Bottom button tests: fallback with Javascript. #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThoWagen
approved these changes
Feb 17, 2025
demiankatz
added a commit
that referenced
this pull request
Feb 17, 2025
This reverts commit a038f30.
|
This didn't help, so I reverted the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window resizing doesn't seem to compensate for Mink framework glitches in bottom button tests 100% of the time; this adds more fallback logic designed to prevent false-positive Jenkins failures.
I tried to implement the click fallback without using jQuery but couldn't get it to work. Since this is (hopefully) only a short-term workaround, I didn't devote a huge amount of time to solving that problem.