Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove param for unconf addr #50

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Remove param for unconf addr #50

merged 1 commit into from
Feb 1, 2024

Conversation

altafan
Copy link
Collaborator

@altafan altafan commented Feb 1, 2024

With newer elements version, the getnewaddress rpc returns by default a confidential segwit v0 address.

This removes the bech32 param used by the /address endpoint when calling the underlying rpc, to prevent generating unconfidential addresses.

Please @bordalix review this.

@altafan altafan requested a review from bordalix February 1, 2024 19:03
@tiero tiero merged commit 5b9f4da into master Feb 1, 2024
3 checks passed
Copy link

@bordalix bordalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants