-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vultr container registry resource #445
Conversation
I fixed golint and added resources to terrafrom code |
I'd really like to see this merged! I'm no Go expert, but I can hack on this and try to resolve the conflicts if needed. |
Sorry for the delay! I'll test this out and merge it this afternoon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for the most part. The tests aren't valid based on the requirements of the API, so that should be fixed. Some of the data schema isn't completely accurate either. Ideally this would include some documentation in the website/docs/r
directory, but that can be added later.
A data_source
for container registry would be nice to have, but not crucial to the basic functionality here. Another nice thing to have would be validation on the name field to ensure that the limited set of characters isn't allowed through. But neither of those are blockers for this PR.
Sure. I think we can make PR better before merging into the main |
Is there anything I can do to help with this one? Pretty keen to see this merged. |
I just tested things out and it's working. There are a few things I'd like to see cleaned up, and the name validation currently won't account for names with non-alphanumeric characters, but I will address that in a separate PR. I'll get a new release out today or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some updates to follow
Description
Checklist: