Disables parameters and channels inputs for now

vvvv · Nov 8, 2024 · 627a0f1 · 627a0f1
1 parent bc379de
commit 627a0f1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/EffectHost.cs b/src/EffectHost.cs
@@ -54,7 +54,7 @@ internal partial class EffectHost : FactoryBasedVLNode, IVLNode, IComponentHandl
 
     private readonly Pin<IChannel<RectangleF>> boundsPin;
     private readonly Pin<IObservable<IMidiMessage>> midiInputPin, midiOutputPin;
-    private readonly Pin<string> channelPrefixPin;
+    //private readonly Pin<string> channelPrefixPin;
     private readonly Pin<bool> showUiPin;
     private readonly Pin<bool> applyPin;
 
@@ -136,8 +136,8 @@ public EffectHost(NodeContext nodeContext, IVLNodeDescription nodeDescription, s
         Inputs[i++] = boundsPin = new Pin<IChannel<RectangleF>>();
         Inputs[i++] = audioInputPin = new AudioPin();
         Inputs[i++] = midiInputPin = new Pin<IObservable<IMidiMessage>>();
-        Inputs[i++] = new ParametersInput(this);
-        Inputs[i++] = channelPrefixPin = new Pin<string>();
+        //Inputs[i++] = new ParametersInput(this);
+        //Inputs[i++] = channelPrefixPin = new Pin<string>();
         Inputs[i++] = showUiPin = new Pin<bool>();
         Inputs[i++] = applyPin = new Pin<bool>();
 
@@ -235,11 +235,11 @@ public void Update()
             midiInputSubscription.Disposable = midiInput?.Subscribe(HandleMidiMessage);
         }
 
-        if (Acknowledge(ref channelPrefix, channelPrefixPin.Value))
-        {
-            if (!string.IsNullOrEmpty(channelPrefix))
-                LoadChannels(channelPrefix);
-        }
+        //if (Acknowledge(ref channelPrefix, channelPrefixPin.Value))
+        //{
+        //    if (!string.IsNullOrEmpty(channelPrefix))
+        //        LoadChannels(channelPrefix);
+        //}
 
         if (Acknowledge(ref showUI, showUiPin.Value))
         {

diff --git a/src/Startup.cs b/src/Startup.cs
@@ -98,8 +98,9 @@ IVLNodeDescription GetNodeDescription(IVLNodeDescriptionFactory nodeDescriptionF
                 new PinDescription(EffectHost.BoundsInputPinName, typeof(IChannel<RectangleF>)) { IsVisible = false },
                 new PinDescription("Input", typeof(IEnumerable<AudioSignal>)),
                 new PinDescription("Midi In", typeof(IObservable<IMidiMessage>)),
-                new PinDescription("Parameters", typeof(IReadOnlyDictionary<string, float>)),
-                new PinDescription("Channel Prefix", typeof(string), null),
+                // TODO: Bring parameters back via "learn", bring channels back via interface and built-in system in vvvv
+                //new PinDescription("Parameters", typeof(IReadOnlyDictionary<string, float>)),
+                //new PinDescription("Channel Prefix", typeof(string), null),
                 new PinDescription("Show Editor", typeof(bool)),
                 new PinDescription("Apply", typeof(bool), defaultValue: true)
             };