Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6953: merges node and frr exporter under prometheus section #4242

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented Dec 18, 2024

Change Summary

Gather all prometheus exporters under the config section prometheus similar to telegraph

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): config/code consolidation (requires config migration)

Related Task(s)

https://vyos.dev/T6953

Related PR(s)

Component(s) name

monitoring

Proposed changes

Moving currently separate node-exporter and frr-exporter under prometheus umbrella.

How to test

set service monitoring prometheus node-exporter listen-address 192.0.2.1
set service monitoring prometheus frr-exporter listen-address 192.0.2.1

Smoketest result

DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_service_monitoring_prometheus.py
DEBUG - test_01_node_exporter (__main__.TestMonitoringPrometheus.test_01_node_exporter) ... ok
DEBUG - test_02_frr_exporter (__main__.TestMonitoringPrometheus.test_02_frr_exporter) ... ok

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Dec 18, 2024

👍
No issues in PR Title / Commit Title

@nvollmar nvollmar force-pushed the T6953 branch 5 times, most recently from 2d8305d to f544c0c Compare December 18, 2024 14:25
Copy link

github-actions bot commented Dec 18, 2024

✅ No issues found in unused-imports check.. Please refer the workflow run

@nvollmar nvollmar force-pushed the T6953 branch 3 times, most recently from 33e91e6 to 760cdff Compare December 19, 2024 10:02
@nvollmar
Copy link
Contributor Author

failing tests don't seem to be related to this changes

src/conf_mode/service_monitoring_prometheus.py Outdated Show resolved Hide resolved
src/conf_mode/service_monitoring_prometheus.py Outdated Show resolved Hide resolved
@nvollmar nvollmar requested a review from c-po December 20, 2024 06:08
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit 637e4ce into vyos:current Dec 20, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants