-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6953: merges node and frr exporter under prometheus section #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
nvollmar
force-pushed
the
T6953
branch
5 times, most recently
from
December 18, 2024 14:25
2d8305d
to
f544c0c
Compare
✅ No issues found in unused-imports check.. Please refer the workflow run |
nvollmar
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever,
c-po,
fett0,
nicolas-fort and
zdc
as code owners
December 18, 2024 20:41
1 task
nvollmar
force-pushed
the
T6953
branch
3 times, most recently
from
December 19, 2024 10:02
33e91e6
to
760cdff
Compare
failing tests don't seem to be related to this changes |
c-po
requested changes
Dec 19, 2024
CI integration ❌ failed! Details
|
sever-sever
approved these changes
Dec 20, 2024
c-po
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Gather all prometheus exporters under the config section prometheus similar to telegraph
Types of changes
Related Task(s)
https://vyos.dev/T6953
Related PR(s)
Component(s) name
monitoring
Proposed changes
Moving currently separate node-exporter and frr-exporter under prometheus umbrella.
How to test
Smoketest result
Checklist: