Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml: T5738: De-duplicate 'openssh' tagNode #4269

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

indrajitr
Copy link
Contributor

Change Summary

Interface definition for pki has redundant tagNode for openssh. Remove the redundant one.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

pki

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Dec 30, 2024

👍
No issues in PR Title / Commit Title

@indrajitr indrajitr changed the title xml:T5738:De-duplicate 'openssh' tagNode xml: T5738: De-duplicate 'openssh' tagNode Dec 30, 2024
Interface definition for pki has redundant `tagNode`
for `openssh`. Remove the redundant one.
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit e9b1e26 into vyos:current Dec 30, 2024
13 of 14 checks passed
@indrajitr indrajitr deleted the dedu-pki-ssh branch December 30, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants